feat(validation): add release-plan cross-field checks - #338
Merged
hdamker merged 4 commits intoJun 17, 2026
Merged
Conversation
) Add explicit release_plan_check_only_safe metadata so release-plan-safe Python rules survive check-only mode without being tied to release_plan_changed applicability. Reuse derive-release-state outputs for P-033 so release-plan edits are blocked only during active snapshot states, and add P-034 duplicate api_name validation. This leaves published-history, content-drift, and maintenance-release validation for later sessions.
Kevsy
approved these changes
Jun 16, 2026
…validation-session1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement/feature
tests
What this PR does / why we need it:
Adds release-plan cross-field validation for #232:
release_plan_check_only_saferule metadata so selected release-plan rules still run in check-only mode without relying onrelease_plan_changed.derive-release-stateoutput.api_namevalidation forrelease-plan.yaml.P-033 only blocks release-plan changes when an active snapshot branch exists or the derived release state is
snapshot-activeordraft-ready. A planned Release Issue does not block release-plan changes; its issue number is used only as finding context.Which issue(s) this PR fixes:
Related to #232
Special notes for reviewers:
Published-history, content-drift, and maintenance-release validation rules are intentionally left for later work.
Additional context
This PR needs to be merged before the second implementation session for #232 can start.
Changelog input
Additional documentation
This section can be blank.