Skip to content

fix(rules): suppress unactionable S-313 on SinkCredential subtype fields - #408

Merged
hdamker merged 1 commit into
camaraproject:mainfrom
hdamker:fix/s313-suppress-sinkcredential-subtypes
Aug 5, 2026
Merged

fix(rules): suppress unactionable S-313 on SinkCredential subtype fields#408
hdamker merged 1 commit into
camaraproject:mainfrom
hdamker:fix/s313-suppress-sinkcredential-subtypes

Conversation

@hdamker

@hdamker hdamker commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

correction

What this PR does / why we need it:

Adds AccessTokenCredential.allOf.1.properties.accessToken and PrivateKeyJWTCredential.allOf.1.properties.clientId to S-313's suppress_schema_paths allowlist. Both fields are already length-constrained via maxLength; no format/pattern/enum fits an opaque bearer token or a client identifier, same class as the other allowlisted fields. The finding only surfaces once a consuming API's release-snapshot bundler (redocly bundle) materializes these SinkCredential discriminator subtypes as concrete top-level schemas — Commonalities' own lint templates only $ref the base SinkCredential schema and never reach them.

Which issue(s) this PR fixes:

Fixes #407

Special notes for reviewers:

Same known-unactionable class as #401/#406 (the pagination Link header). Full validation/tests suite passes (1218).

Changelog input

 release-note
Suppressed the unactionable S-313 finding on the SinkCredential discriminator subtype fields (AccessTokenCredential.accessToken, PrivateKeyJWTCredential.clientId).

Additional documentation

This section can be blank.

docs

@hdamker
hdamker requested review from Kevsy and rartych as code owners August 5, 2026 16:18
@hdamker
hdamker merged commit b78d56d into camaraproject:main Aug 5, 2026
8 checks passed
@hdamker
hdamker deleted the fix/s313-suppress-sinkcredential-subtypes branch August 5, 2026 16:21
@hdamker hdamker added this to the v0.9.0 milestone Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S-313: suppress the unactionable finding on AccessTokenCredential.accessToken and PrivateKeyJWTCredential.clientId

1 participant