fix(lattice): keep 1-row continuation tables at the 90% whitespace gate - #854
Open
BetterAndBetterII wants to merge 1 commit into
Open
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Lattice._reject_table dropped a last-row-alone-on-next-page table when that 1-row grid sat at the 90% empty-cell threshold (camelot-dev#36 precision gate). stack_contiguous cannot recover a page that emitted zero tables. Fixes camelot-dev#689
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lattice detects a 1-row table when the last row of a multi-page table lands alone on the next page, then
_reject_tabledrops it because a 1-row grid is mostly empty cells (whitespace at the 90% precision gate from #36).stack_contiguouscannot stitch a row the page never emitted, so the last row disappears.Fix
Keep a 1-row grid that has at least one filled cell (
whitespace < 100). Multi-row near-empty grids still drop.Tests
2026-02.Fixes #689