-
Notifications
You must be signed in to change notification settings - Fork 448
Fix/eng 2535 #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix/eng 2535 #592
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d56f561
fix: [ENG-2535] surface daemon version in register ack + drift indica…
bao-byterover 6a3ce81
Merge branch 'main' into fix/ENG-2535
bao-byterover b0d969d
chore: [ENG-2543] bump brv-transport-client to 1.1.0
bao-byterover 8076a6e
fix: [ENG-2541] render daemon-version drift indicator inline in heade…
bao-byterover c65ba66
fix: [ENG-2541] address PR review nits on drift surfaces
bao-byterover 600dc61
Merge branch 'main' into fix/ENG-2535
bao-byterover File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import {versionsAreEquivalent} from '@campfirein/brv-transport-client' | ||
|
|
||
| /** | ||
| * Appends a version-drift footer to MCP tool text responses when the MCP | ||
| * client and the running daemon are at different versions. | ||
| * | ||
| * Returns the body unchanged when versions match or when the daemon hasn't | ||
| * reported its version yet (pre-fix daemon during a rolling upgrade). | ||
| */ | ||
| export function appendDriftFooter(body: string, clientVersion: string, daemonVersion?: string): string { | ||
| if (!daemonVersion || versionsAreEquivalent(clientVersion, daemonVersion)) { | ||
| return body | ||
| } | ||
|
|
||
| return ( | ||
| body + | ||
| `\n\n---\nNote: this brv MCP is at ${clientVersion} while the running daemon is at ${daemonVersion}. ` + | ||
| `The protocol is backward-compatible. Restart your IDE to align versions.` | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.