[Backport 2.8] Use with statement for the SMTP connection #11748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
backport/11745-to-2.8
branch
2 times, most recently
from
fcc738b to
0fb0be0
Compare
sbrunner
force-pushed
the
backport/11745-to-2.8
branch
from
0fb0be0 to
0730bcd
Compare
sbrunner
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11745
Error on cherry picking:
Error on backporting to branch 2.8, error on cherry picking e02b0f8:
To continue do:
git fetch && git checkout backport/11745-to-2.8 && git reset --hard HEAD^
git cherry-pick e02b0f8
git cherry-pick cbc3a87
git push origin backport/11745-to-2.8 --force