Fix AttributeError: run with Odoo 14/15 #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrus-v
added a commit
to petrus-v/oca-custom
that referenced
this pull request
Jun 18, 2025
waiting for camptocamp/pytest-odoo#85
StephaneMangin
approved these changes
Jun 18, 2025
florentx
reviewed
Jun 18, 2025
Contributor
florentx
left a comment
florentx
left a comment
There was a problem hiding this comment.
I'm afraid that tests will no longer be run, with such change.
Method was calling super().run(...).
If you replace by a stub method, there will be no run.
florentx
reviewed
Jun 18, 2025
'hasattr(BaseCase, "run")' returns True even if 'run' is only inherited from a parent class, which causes 'del BaseCase.run' to raise an AttributeError. We now catch the exception instead of checking with hasattr, to ensure compatibility across Odoo versions where 'run' may or may not be defined directly on BaseCase.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage ? 35.48%
=========================================
Files ? 1
Lines ? 124
Branches ? 0
=========================================
Hits ? 44
Misses ? 80
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
florentx
changed the title
florentx
changed the title
florentx
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #84