Skip to content

purge unprocessed USB out transfers - #316

Merged
marckleinebudde merged 2 commits into
candle-usb:masterfrom
marckleinebudde:purge-unprocessed-usb-out-transfers
Jul 15, 2026
Merged

purge unprocessed USB out transfers#316
marckleinebudde merged 2 commits into
candle-usb:masterfrom
marckleinebudde:purge-unprocessed-usb-out-transfers

Conversation

@marckleinebudde

@marckleinebudde marckleinebudde commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

This fixes the following error messages, which might occur during suspend/resume:

[175499.859858] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 0
[175499.859955] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 1
[175499.859977] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 2
[175499.859994] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 3
[175499.860075] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 4
[175499.860097] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 5
[175499.860205] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 6
[175499.860227] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 7
[175499.860347] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 8
[175499.860368] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 9

While #301 purges pending USB in transfers, this PR purges unprocessed USB out transfers.

…ion to purge all frames of a channel from channel->list_from_host

Extending the idea of commit 78c943d ("usbd_gs_can:
usbd_gs_can_purge_to_host_list_by_channel(): add function to purge all
frames of a channel from hGS_CAN.list_to_host") to the list_from_host.

After a USB USB suspend or disconnect event it makes no sense makes no
sense to process old data.

Add a new function `usbd_gs_can_purge_from_host_list_by_channel()` that
removes all outgoing frames of a channel from `channel->list_from_host`.
…channels list_from_host on CAN channel shutdown

In case a CAN channel is shut down, remove all unprocessed USB OUT
transfers for that channel from `channel->list_from_host`.

`can_disable()` is called from the `USBD_GS_CAN_SuspendCallback()`, by
purging all incoming frames avoids unexpected processing on USB OUT
transfers after resume, which may lead to the following error messages:

```
[175499.859858] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 0
[175499.859955] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 1
[175499.859977] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 2
[175499.859994] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 3
[175499.860075] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 4
[175499.860097] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 5
[175499.860205] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 6
[175499.860227] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 7
[175499.860347] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 8
[175499.860368] gs_usb 2-1.2:1.0 can0: Unexpected unused echo id 9
```
@marckleinebudde
marckleinebudde merged commit 9f4c4a0 into candle-usb:master Jul 15, 2026
48 checks passed
@marckleinebudde
marckleinebudde deleted the purge-unprocessed-usb-out-transfers branch July 15, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant