Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate deterministic expressions #841

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Deduplicate deterministic expressions #841

merged 11 commits into from
Jan 11, 2024

Conversation

MarcelGarus
Copy link
Member

@MarcelGarus MarcelGarus commented Dec 14, 2023 •
edited
Loading

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@jwbot jwbot added the P: Compiler: Frontend Package: The compiler frontend label Dec 14, 2023
@JonasWanke JonasWanke changed the title Remove expressions after panic Deduplicate deterministic expressions Dec 14, 2023
@JonasWanke JonasWanke added the T: Feature Type: New Features label Dec 14, 2023
@jwbot
Copy link
Collaborator

jwbot commented Dec 14, 2023

The golden IRs have changed: cfce928..0044f13

@jwbot
Copy link
Collaborator

jwbot commented Dec 19, 2023

The golden IRs have changed: cfce928..ba70af4

@jwbot
Copy link
Collaborator

jwbot commented Dec 19, 2023

The golden IRs have changed: cfce928..09bd6d1

@MarcelGarus MarcelGarus marked this pull request as ready for review January 6, 2024 15:23
@jwbot jwbot enabled auto-merge January 6, 2024 15:23
JonasWanke
JonasWanke requested changes Jan 7, 2024
View reviewed changes
Copy link
Member

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I just have some simplification suggestions and requests for comments in the code

@JonasWanke JonasWanke mentioned this pull request Jan 11, 2024
Merged
2 tasks
@jwbot
Copy link
Collaborator

jwbot commented Jan 11, 2024

The golden IRs have changed: cfce928..c8179ab

@jwbot
Copy link
Collaborator

jwbot commented Jan 11, 2024

The golden IRs have changed: cfce928..1e41790

@jwbot jwbot merged commit c85f2ac into main Jan 11, 2024
11 checks passed
@jwbot jwbot deleted the optimize-deterministic-stuff branch January 11, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasWanke JonasWanke JonasWanke approved these changes

Assignees

@MarcelGarus MarcelGarus

Labels
P: Compiler: Frontend Package: The compiler frontend T: Feature Type: New Features
Projects
🍭 Candy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcelGarus @jwbot @JonasWanke