Skip to content

fix(crypto): update dependency with portable security fixes - #186

Merged
dangfan merged 2 commits into
devfrom
codex/crypto-security-performance
Oct 10, 2026
Merged

dangfan merged 2 commits into
devfrom
codex/crypto-security-performance

Conversation

@dangfan

@dangfan dangfan commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Update canokey-crypto from 59d1a986 to the merged upstream master commit f9382dc2, including defined SM3 rotations and unaligned accesses, alignment-independent Keccak byte interfaces, full-length RSA CRT factor comparison, probe erasure, and CRT rejection regression tests.

The dependency also contains the existing upstream additive caller-owned scratch APIs. Core keeps its current call sites and scratch ownership; no core source, applet, protocol, storage layout, or build configuration changes are included. The final diff against dev is only the canokey-crypto gitlink.

Validation:

  • Rebuilt CIU DevKit and NFCC Release firmware with this exact dependency revision; both fit (DevKit Flash 158884 B / RAM 8288 B; NFCC Flash 162816 B / RAM 8420 B).
  • RSA regression CTest passed with AppleClang Debug/AddressSanitizer on the identical crypto tree before upstream PR upgrade crypto #22 was merged.
  • Earlier backport validation passed all eight macOS-compatible core suites and dedicated DevKit crypto/product HIL; those hardware runs used the prior crypto pin 54fc0812 and were not repeated for this dependency update.
  • git diff --check passed. Linux CI results remain pending.

Depends on the already merged canokeys/canokey-crypto#22. Target branch: dev.

Summary by CodeRabbit

  • Chores
    • Updated the underlying cryptographic component. No user-facing behavior changes are noted in this update.

Update canokey-crypto with SM3 defined rotations and unaligned access, alignment-independent Keccak byte interfaces, and full-length RSA CRT factor equality checking. Retain all existing C APIs and dependency paths; omit caller-owned scratch changes.
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d2ad64db-cc4d-4391-8966-a8cccb8a5da5

📥 Commits

Reviewing files that changed from the base of the PR and between e558d5c and 1b9c78d.


📒 Files selected for processing (1)
  • canokey-crypto

 _________________________________________
< Here's Johnny! Ready to axe those bugs. >
 -----------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dangfan
dangfan merged commit d8f5955 into dev Oct 10, 2026
9 of 13 checks passed
@dangfan
dangfan deleted the codex/crypto-security-performance branch October 10, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant