Repository navigation
fix(crypto): update dependency with portable security fixes - #186
Merged
Merged
Conversation
Update canokey-crypto with SM3 defined rotations and unaligned access, alignment-independent Keccak byte interfaces, and full-length RSA CRT factor equality checking. Retain all existing C APIs and dependency paths; omit caller-owned scratch changes.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update canokey-crypto from 59d1a986 to the merged upstream master commit f9382dc2, including defined SM3 rotations and unaligned accesses, alignment-independent Keccak byte interfaces, full-length RSA CRT factor comparison, probe erasure, and CRT rejection regression tests.
The dependency also contains the existing upstream additive caller-owned scratch APIs. Core keeps its current call sites and scratch ownership; no core source, applet, protocol, storage layout, or build configuration changes are included. The final diff against dev is only the canokey-crypto gitlink.
Validation:
Depends on the already merged canokeys/canokey-crypto#22. Target branch: dev.
Summary by CodeRabbit