Repository navigation
build: depend on the published crates.io canokey-c crate - #6
Conversation
Replace the libcanokey Git revision pin (b709b3d) with the published canokey-c 0.1.0 crate from crates.io. The published C ABI header is byte-identical to the pinned revision, and the full macOS Debug build plus all 12 CTest contracts pass with the crates.io source. Cargo.lock now records the crates.io registry checksum for canokey-c and its sibling canokey-* crates. Update the build documentation in README, architecture.md, AGENTS.md, and the libcanokey.cmake comment to describe the crates.io dependency instead of the Git pin. Signed-off-by: Fan DANG <i@dang.fan>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Rust dependency changes from a pinned Git revision to the published crates.io ChangesPublished
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The published dependency is documented and no merge-blocking behavior is evidenced. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace the libcanokey Git revision pin (b709b3d) with the published canokey-c 0.1.0 crate from crates.io. The published C ABI header is byte-identical to the pinned revision, and the full macOS Debug build plus all 12 CTest contracts pass with the crates.io source.
Cargo.lock now records the crates.io registry checksum for canokey-c and its sibling canokey-* crates. Update the build documentation in README, architecture.md, AGENTS.md, and the libcanokey.cmake comment to describe the crates.io dependency instead of the Git pin.
Summary by CodeRabbit
Build & Compatibility
canokey-crelease, providing a consistent dependency source while preserving existing PIV feature support.Documentation