-
Notifications
You must be signed in to change notification settings - Fork 7
WIP: re-add s390x and ppc64el arches in func tests #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To see if it fixes the issue with zaza and cgroups with juju
we already have the precedent for pinning cryptography
To see if we can get unblocked, at least for focal ubuntu charm on ppc64el and s390x does not support jammy or noble
| runs-on: [[ubuntu-24.04], [arm64, noble, self-hosted], [s390x, noble, self-hosted], [ppc64el, noble, self-hosted]] | ||
| test-command: ['tox -e func'] | ||
| juju-channel: ["3.4/stable"] | ||
| juju-channel: ["3.6/stable"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we ok with upgrading to juju 3.6 for func tests in general? @Pjack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot answer it now. But we will track it in canonical/solutions-engineering-automation#227
| @@ -1,2 +1,2 @@ | |||
| git+https://github.com/openstack-charmers/zaza.git@master#egg=zaza | |||
| git+https://github.com/samuelallan72/zaza.git@unpin-cryptography#egg=zaza | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the biggest thing we need to figure out. Whether to try to unpin cryptography in zaza (preferred), or get the old cryptography python package revision building on s390x and ppc64el.
TODO: revert this line once it's fixed upstream (or we figure out a workaround).
tests/functional/tests/tests.yaml
Outdated
| # - noble | ||
| # - jammy | ||
| - focal | ||
| smoke_bundles: | ||
| - jammy | ||
| - focal | ||
| # - jammy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: revert this when the ubuntu charm pushes releases supporting noble and jammy on s390x and ppc64el.
.github/workflows/check.yaml
Outdated
| # - name: Update system PATH for running pipx software | ||
| # run: | | ||
| # echo "$HOME/.local/bin" >> "$GITHUB_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be deleted - this step was only required for the enterprise arm64 runner (now the setup-python step is gone). But I'm sure we'll be wanting to move away from that runner for all our projects (to use either our self hosted runners or the new public free github-hosted arm64 runners).
|
@chanchiwai-ray I'll close this PR and openstack-charmers/zaza#680 now that I'm no longer at the company. Please re-open the PRs from your account. 🙂 Everything here should be explained in comments on the PR, or on the internal doc and ticket. Please ping me on github though if anything is unclear. :) |
ref. canonical/solutions-engineering-automation#206