Check different ISHTP modules according to the release (Bugfix) #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1684 +/- ##
==========================================
+ Coverage 50.16% 50.20% +0.04%
==========================================
Files 381 382 +1
Lines 40856 40894 +38
Branches 6857 6866 +9
==========================================
+ Hits 20494 20530 +36
- Misses 19632 19633 +1
- Partials 730 731 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please merge this PR with main to fix the issues with the SRU gate. |
fernando79513
added
the
waiting-for-changes
LiaoU3
removed
the
waiting-for-changes
|
@fernando79513 Please review it when you have time. |
Hook25
approved these changes
Apr 18, 2025
Meulengracht
pushed a commit
to Meulengracht/checkbox
that referenced
this pull request
May 19, 2025
…nical#1684) * Check different modules according to the release * Replace shell script with python script * Black format * Fix flake8 * Fix check * Replace f-string with format string * Adopt suggestion from Fernando * Fix mock output * Fix codecov and tox * Remove ishtp.py from test folder * Extend code coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue was originally found from LP#2077844
After 24.04 (to be more precise, after kernel 5.15), the module
intel_ishtp_loaderwill not be automatically loaded anymomre. Hence, the modules we need to check will be different due to the series.The commit that cause the change in Linux git repo is over here.
Resolved issues
LP#2077844
Documentation
N/A
Tests
https://certification.canonical.com/hardware/202407-34230/submission/408436/