Return override list in the right order (bugfix) #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
- Coverage 50.16% 50.15% -0.01%
==========================================
Files 381 381
Lines 40856 40856
Branches 6857 6857
==========================================
- Hits 20494 20490 -4
- Misses 19632 19635 +3
- Partials 730 731 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The overrides are visited in this order: - inline overrides - category overrides - certification status overrides They should be returned in the same order (not sorted), so that they are applied in the same order (meaning certifiaction status overrides should overwrite any inline overrides). Fix #1492
pieqq
force-pushed
the
1492-override-list
branch
from
1afcf80 to
4852cb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The overrides are visited in this order:
They should be returned in the same order (not sorted), so that they are applied in the same order (meaning certifiaction status overrides should overwrite any inline overrides).
Resolved issues
Fix #1492
Documentation
Tests