Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog #311

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Add changelog #311

merged 7 commits into from
Jan 21, 2025

Conversation

alithethird
Copy link
Collaborator

@alithethird alithethird commented Jan 20, 2025

Overview

Add a changelog file and populated it with recent changes.

Rationale

Changelog file makes tracking changes really easy and it is important that every repo has it.

Juju Events Changes

No changes made to Juju events.

Module Changes

No changed made to code.

Library Changes

No changes made to code.

Checklist

@alithethird alithethird added the documentation Improvements or additions to documentation label Jan 20, 2025
@alithethird alithethird self-assigned this Jan 20, 2025
@alithethird alithethird requested a review from a team as a code owner January 20, 2025 07:14
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fill in the PR template and give a bit of context (so fill in the Rationale section)? I think you might also want to update the PR template with a line like - [ ] The changelog is updated..

@alithethird alithethird requested a review from cbartz January 20, 2025 11:19
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alithethird alithethird requested a review from cbartz January 20, 2025 11:34
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the changelog!

Copy link
Contributor

Test coverage for b0fd628

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        373     41     84     15    87%   184, 192-193, 205, 337->345, 378->383, 395, 584-586, 591-592, 604-606, 611-612, 624-626, 649-651, 693->exit, 703->exit, 752-755, 765-766, 790-791, 803-804, 831-833, 835->840, 837-838, 880-881, 897-898, 908->exit, 922
src/database.py      29      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               402     42     92     16    88%

Static code analysis report

Run started:2025-01-20 12:44:11.772787

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2478
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@alithethird alithethird merged commit c742ac6 into main Jan 21, 2025
21 checks passed
@alithethird alithethird deleted the add-changelog branch January 21, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants