Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hockeypuck rock and update charm files #3

Merged
merged 18 commits into from
Jan 20, 2025
Merged

Conversation

swetha1654
Copy link
Collaborator

@swetha1654 swetha1654 commented Jan 15, 2025

Applicable spec:

Overview

  • Developed the hockeypuck rock to contain the required binaries and templates in the respective folders.
  • Developed a wrapper script that substitutes variables in the hockeypuck config file with environment variables and writes to hockeypuck.conf. The script then calls the hockeypuck binary.
  • Updated charmcraft.yaml and metadata.yaml

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

There is no charmhub documentation available yet.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 44 files.

Valid Invalid Ignored Fixed
12 2 30 0
Click to see the invalid file list
  • hockeypuck_rock/hockeypuck.conf.tmpl
  • hockeypuck_rock/hockeypuck_wrapper.sh
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

hockeypuck_rock/hockeypuck_wrapper.sh Outdated Show resolved Hide resolved
@swetha1654 swetha1654 marked this pull request as ready for review January 15, 2025 15:08
@swetha1654 swetha1654 requested a review from a team as a code owner January 15, 2025 15:08
@swetha1654 swetha1654 requested review from amandahla, weiiwang01, seb4stien, arturo-seijas and gregory-schiano and removed request for a team, amandahla and weiiwang01 January 15, 2025 15:08
@swetha1654 swetha1654 changed the title Develop rock and update charm files Create hockeypuck rock and update charm files Jan 15, 2025
metadata.yaml Outdated Show resolved Hide resolved
metadata.yaml Outdated Show resolved Hide resolved
metadata.yaml Outdated Show resolved Hide resolved
metadata.yaml Outdated Show resolved Hide resolved
metadata.yaml Outdated Show resolved Hide resolved
metadata.yaml Outdated Show resolved Hide resolved
metadata.yaml Outdated Show resolved Hide resolved
.trivyignore Outdated Show resolved Hide resolved
Copy link

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the metadata.yaml file part of the template? If so, con you remove it there too?

.licenserc.yaml Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@swetha1654
Copy link
Collaborator Author

swetha1654 commented Jan 16, 2025

Is the metadata.yaml file part of the template? If so, con you remove it there too?

yes it is. sure, will make changes there too!

@swetha1654
Copy link
Collaborator Author

swetha1654 commented Jan 16, 2025

Is the metadata.yaml file part of the template? If so, con you remove it there too?

Raised a PR for the same: canonical/is-charms-template-repo#25

@swetha1654 swetha1654 requested a review from seb4stien January 17, 2025 10:16
@swetha1654 swetha1654 requested a review from weiiwang01 January 20, 2025 05:59
Copy link

Test coverage for fb2b58e

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      31     19      4      0    34%   37-39, 53-60, 74-94, 99
----------------------------------------------------------
TOTAL             31     19      4      0    34%

Static code analysis report

Run started:2025-01-20 06:38:01.605231

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 157
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@swetha1654 swetha1654 merged commit afbbcc7 into main Jan 20, 2025
18 checks passed
@swetha1654 swetha1654 deleted the ISD-2842-rockcraft branch January 20, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants