capi docs: add intermediate ca how-to #1027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrutlucian94
force-pushed
the
lpetrut/intermediate-ca-docs
branch
2 times, most recently
from
0ae6dab to
d3fb20e
Compare
We're adding a guide that shows how intermediate CAs can be generated using HashiCorp Vault and passed to CAPI using management cluster secrets.
petrutlucian94
force-pushed
the
lpetrut/intermediate-ca-docs
branch
from
d3fb20e to
90fb1ca
Compare
nhennigan
reviewed
Jan 31, 2025
| for the workload clusters. | ||
|
|
||
| Follow this guide to prepare an intermediate Certificate Authority (CA) using | ||
| HashiCorp Vault and then configure ClusterAPI to use the generated certificates. |
There was a problem hiding this comment.
Can we provide a link to Vault please?
| @@ -22,6 +22,7 @@ Perform an in-place upgrade <in-place-upgrades> | |||
| Upgrade the providers of a management cluster <upgrade-providers> | |||
| Migrate the management cluster <migrate-management> | |||
| Refresh workload cluster certificates <refresh-certs> | |||
| How to use intermediate CAs with Vault <intermediate-ca> | |||
There was a problem hiding this comment.
Please rename Use intermediate CAs with Vault
| vault secrets tune -max-lease-ttl=87600h pki | ||
| ``` | ||
|
|
||
| ## Generating the CA certificates |
There was a problem hiding this comment.
nit: Generate the CA certificates
| Follow this guide to prepare an intermediate Certificate Authority (CA) using | ||
| HashiCorp Vault and then configure ClusterAPI to use the generated certificates. | ||
|
|
||
| ## Preparing Vault |
| > myca/intermediate.crt | ||
| ``` | ||
|
|
||
| ## Passing intermediate CA certificates to CAPI |
There was a problem hiding this comment.
nit: Pass intermediate ...
| tls.key: | | ||
| $(cat myca/intermediate.key | sed 's/^/ /g') | ||
| EOF | ||
|
|
There was a problem hiding this comment.
I would separate these code blocks and add a line saying now apply the CA cert to the cluster
| For the purpose of this guide, we are going to install HashiCorp Vault using | ||
| snap and start a Vault server in development mode. | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
nit: Can you please remove the bash from the code snippets? Generally we leave them blank unless there is a real need so that the output looks the same across pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding a guide that shows how intermediate CAs can be generated using HashiCorp Vault and passed to CAPI using management cluster secrets.