Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: Address some of the TICS failures #988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

actions: Address some of the TICS failures #988

wants to merge 1 commit into from

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jan 20, 2025

There are some errors in the TICS job, even though the job passes. Some of these errors relate to some missing dependencies for pylint.

There is one other notable type of error (hundreds of errors), related to Coverity:

[ERROR 5336] No analysis data found for file '/home/runner/work/k8s-snap/k8s-snap/src/k8s/pkg/k8sd/controllers/csrsigning/const.go' in 'Coverity'. Please check if the file is analyzed properly, and whether the file is in the analysis scope of the tool.

These errors are currently unsolvable. The current version of TICS comes with the Coverity 2024.9.0 version (as seen in cov-build-console.log):

Coverity Build Capture (64-bit) version 2024.9.0 on Linux 6.8.0-1020-azure x86_64
Internal version numbers: 950e903b4e p-2024.9-push-30

According to the Coverity documentation [1], this version of Coverity only supports golang 1.21 and 1.22, while this project is built on golang 1.23. Coverity 2024.12.0 supports golang 1.23 as well.

[1] https://documentation.blackduck.com/bundle/coverity-on-polaris-UAT/page/topics/r_coverity-compatible-platforms_2024.9.html

@claudiubelu claudiubelu requested a review from a team as a code owner January 20, 2025 12:17
@claudiubelu claudiubelu marked this pull request as draft January 20, 2025 12:17
@claudiubelu claudiubelu force-pushed the tics branch 3 times, most recently from 1a9267e to 73f8101 Compare January 20, 2025 16:11
There are some errors in the TICS job, even though the job passes. Some
of these errors relate to some missing dependencies for pylint.

There is one other notable type of error (hundreds of errors), related
to Coverity:

[ERROR 5336] No analysis data found for file '/home/runner/work/k8s-snap/k8s-snap/src/k8s/pkg/k8sd/controllers/csrsigning/const.go' in 'Coverity'. Please check if the file is analyzed properly, and whether the file is in the analysis scope of the tool.

These errors are currently unsolvable. The current version of TICS comes
with the Coverity 2024.9.0 version (as seen in cov-build-console.log):

Coverity Build Capture (64-bit) version 2024.9.0 on Linux 6.8.0-1020-azure x86_64
Internal version numbers: 950e903b4e p-2024.9-push-30

According to the Coverity documentation [1], this version of Coverity
only supports golang 1.21 and 1.22, while this project is built on
golang 1.23. Coverity 2024.12.0 supports golang 1.23 as well.

[1] https://documentation.blackduck.com/bundle/coverity-on-polaris-UAT/page/topics/r_coverity-compatible-platforms_2024.9.html
@claudiubelu claudiubelu marked this pull request as ready for review January 27, 2025 16:17
pip install requests jinja2 semver

# Integration tests are importing a local test_util module. Needed for pylint.
export PYTHONPATH="$(pwd)/tests/integration/tests"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we append this to the pythonpath instead of overriding it completely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants