Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skip_ssl_verify optional to keep bakcwards compatibility #64

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Aug 14, 2024

Applicable spec:

Overview

Make skip_ssl_verify optional to keep bakcwards compatibility

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@arturo-seijas arturo-seijas requested a review from a team as a code owner August 14, 2024 07:43
Copy link

Test coverage for 9ca6eb1

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
lib/charms/smtp_integrator/v0/smtp.py     128      2     24      2    97%   336, 338
src/charm.py                               82      5     26      1    94%   91-93, 102-103
src/charm_state.py                         46      0      6      0   100%
-----------------------------------------------------------------------------------
TOTAL                                     256      7     56      3    97%

Static code analysis report

Run started:2024-08-14 07:45:56.971780

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 913
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 3e70626 into main Aug 14, 2024
22 checks passed
@arturo-seijas arturo-seijas deleted the fix-backwards-compatibility branch August 14, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants