Secrets support

[arturo-seijas]

Applicable spec: https://docs.google.com/document/d/13K6TlXI2b_Hg0-0_b0LeMhPJ3WVdfJtFPsImVRgiFNc

Overview

Support sharing secrets via relation, as per the spec above. Note that support for Juju 2 will land in a separate PR

Rationale

N/A

Juju Events Changes

• Config changed: secret is stored now here
• New relation created event for the new relation

Module Changes

charm.py and charm_state.py

Library Changes

Added new relation to the library

Checklist

• The charm style guide was applied
• The contributing guide was applied
• The changes are compliant with ISD054 - Managing Charm Complexity
• The documentation is generated using src-docs
• The documentation for charmhub is updated
• The PR is tagged with appropriate label (urgent, trivial, complex)

[mthaddon]

Have just done a pass on the docs. Looking very good mostly in terms of docs, just some minor comments, thanks.

[cbartz]

I mostly found typos

[github-actions]

Test coverage for c79c582

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
lib/charms/smtp_integrator/v0/smtp.py     110      2     16      2    97%   283, 285
src/charm.py                               55      2     14      2    94%   87, 89
src/charm_state.py                         48      0      8      0   100%
-----------------------------------------------------------------------------------
TOTAL                                     213      4     38      4    97%

Static code analysis report

Run started:2023-10-25 07:43:19.616001

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 789
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

[cbartz]

Looks good to me, just a few minor things.
Could you add the spec (or name as I believe its private) in the PR description? Thanks very much.

[gregory-schiano]

LGTM