Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #81

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Update README.md #81

merged 10 commits into from
Jan 16, 2025

Conversation

weiiwang01
Copy link
Contributor

Applicable spec:

Overview

Update README.md with the new template.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@weiiwang01 weiiwang01 added the documentation Improvements or additions to documentation label Dec 19, 2024
@weiiwang01 weiiwang01 requested a review from a team as a code owner December 19, 2024 17:06
@weiiwang01 weiiwang01 requested a review from erinecon December 19, 2024 17:06
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this README!

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
arturo-seijas
arturo-seijas previously approved these changes Jan 8, 2025
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
arturo-seijas
arturo-seijas previously approved these changes Jan 10, 2025
erinecon
erinecon previously approved these changes Jan 10, 2025
@weiiwang01 weiiwang01 dismissed stale reviews from erinecon and arturo-seijas via 5c5cd21 January 13, 2025 05:05
.licenserc.yaml Outdated Show resolved Hide resolved
arturo-seijas
arturo-seijas previously approved these changes Jan 13, 2025
Copy link

Test coverage for 6ebf95c

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
lib/charms/smtp_integrator/v0/smtp.py     130      2     22      2    97%   340, 342
src/charm.py                               82      5     26      1    94%   91-93, 102-103
src/charm_state.py                         46      0      0      0   100%
-----------------------------------------------------------------------------------
TOTAL                                     258      7     48      3    97%

Static code analysis report

Run started:2025-01-13 14:50:59.969695

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 926
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README!
(I gave this an official approval because, as far as I can tell, all of the code changes are to update the license headers.)

@weiiwang01 weiiwang01 merged commit 1301d0a into main Jan 16, 2025
23 checks passed
@weiiwang01 weiiwang01 deleted the update-readme branch January 16, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants