Skip to content

Conversation

yanksyoon
Copy link
Member

Applicable spec:

Overview

Updates README.md to conform to latest standards.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@yanksyoon yanksyoon added documentation Improvements or additions to documentation trivial labels Dec 17, 2024
@yanksyoon yanksyoon requested a review from a team as a code owner December 17, 2024 02:58
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README! It looks great, just one comment from me :)

@yanksyoon yanksyoon requested a review from erinecon December 18, 2024 03:01
erinecon
erinecon previously approved these changes Dec 18, 2024
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README!

Copy link
Contributor

Lint checks failed for ffe7766

```

tests/integration/conftest.py:90: error: Incompatible types in assignment (expression has type "Type | None", variable has type "MachineStatus") [assignment]
Found 1 error in 1 file (checked 20 source files)

Copy link
Contributor

Test coverage for ffe7766

Name               Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------
src/actions.py        22      0      2      0   100%
src/charm.py          62      0      6      0   100%
src/ssh_debug.py      27      0      4      0   100%
src/state.py          45      0      6      0   100%
src/tmate.py         136      0     12      0   100%
--------------------------------------------------------------
TOTAL                292      0     30      0   100%

Static code analysis report

Run started:2025-01-14 07:07:42.506756

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1677
  Total lines skipped (#nosec): 9
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147
Copy link
Contributor

Hi @yanksyoon, it seems like there's a lint issue, can you take a look? Thanks!

@erinecon erinecon merged commit 798d19d into main Feb 19, 2025
18 checks passed
@erinecon erinecon deleted the docs/readme branch February 19, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Libraries: Out of sync trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants