Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade training-operator 1.8.0 -> 1.9.0 #214

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Feb 4, 2025

This commit upgrades the template files that are used to deploy the training-operator. It also adds an example JAX job for it to be tested.

This commit upgrades the template files that are used to deploy the training-operator.
It also adds an example JAX job for it to be tested.
mvlassis
mvlassis previously approved these changes Feb 4, 2025
Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the process of diffing the manifests and I get the same results.

Note that there is an issue with the testing of the newly created jaxjob

@DnPlas
Copy link
Contributor Author

DnPlas commented Feb 5, 2025

I went through the process of diffing the manifests and I get the same results.

Note that there is an issue with the testing of the newly created jaxjob

I believe Jaxjobs are missing in the aggregation clusterroles for kubeflow, I have created an issue kubeflow/trainer#2416. We can block merging this PR until we get a reply from the WG.

@DnPlas
Copy link
Contributor Author

DnPlas commented Feb 7, 2025

@mvlassis ready for another review. The jaxjob check should pass now. Please note that the CI will still fail because of chisme's version. Please review and approve #215 first.

mvlassis
mvlassis previously approved these changes Feb 13, 2025
Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@DnPlas DnPlas merged commit 057bb31 into main Feb 14, 2025
10 checks passed
@DnPlas DnPlas deleted the KF-6873-upgrade-1.9.0 branch February 14, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants