Skip to content

Conversation

@Maha14-ui
Copy link
Collaborator

@Maha14-ui Maha14-ui commented Dec 3, 2025

closes : https://jsw.ibm.com/browse/MAXUIF-3195?filter=-1

Summary

  • here I have updated the fix for access related issues for dashboard value component.
  • issues :
  • Content is not within a landmark element
  • Accessible name does not match or contain the visible label text
    components from carbon-addon-iot-react mentioned below.
  1. valueCard component
  2. gaugeCard

Change List (commits, features, bugs, etc)

  • items_here

Acceptance Test (how to verify the PR)

  • tests here
    Before :
Screenshot 2025-12-03 at 4 24 37 AM Screenshot 2025-12-03 at 4 25 30 AM Screenshot 2025-12-03 at 4 25 40 AM After : Screenshot 2025-12-03 at 12 33 44 AM Screenshot 2025-12-03 at 6 19 33 PM Screenshot 2025-12-03 at 6 20 09 PM

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit a5f06a7
🔍 Latest deploy log https://app.netlify.com/projects/carbon-addons-iot-react/deploys/69398e62ce928f000815d724
😎 Deploy Preview https://deploy-preview-4049--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Maha14-ui Maha14-ui requested a review from aqibibm December 3, 2025 08:18
attribute.secondaryValue && {
...attribute.secondaryValue,
value: determineValue(attribute.secondaryValue.dataSourceId, values),
<section id="main-content" aria-label="value content">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use same div to give aria-label instead of having

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @aqibibm , I have tried to repeat the issues from reference-app. issue (Content is not within a landmark element) was not repeating and main tag and role is already available from main page so these changes are not required. I have reverted these changes. and updated the PR. please review. Thank you!.

/>
<text
id="gauge-label"
<section id="main-content" aria-label="region">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @aqibibm ,as I said above. I have reverted these changes. and updated the PR. please review. Thank you!.

@Maha14-ui
Copy link
Collaborator Author

hi @aqibibm and Team , I was able to reproduce the issue “Accessible name does not match or contain the visible label text.”
I have fixed it in the index.js file and verified the fix in the reference-app through Graphite using my local PAL changes.
updated test ss below. please review the latest changes. Thank you!
Before :

Screenshot 2025-12-09 at 5 17 12 PM After : ------ Screenshot 2025-12-10 at 6 28 36 PM Screenshot 2025-12-10 at 6 28 43 PM

@Maha14-ui Maha14-ui requested a review from aqibibm December 10, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants