-
Notifications
You must be signed in to change notification settings - Fork 82
fix: updated the fix for access related issues in dashboard component #4049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for carbon-addons-iot-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| attribute.secondaryValue && { | ||
| ...attribute.secondaryValue, | ||
| value: determineValue(attribute.secondaryValue.dataSourceId, values), | ||
| <section id="main-content" aria-label="value content"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use same div to give aria-label instead of having
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @aqibibm , I have tried to repeat the issues from reference-app. issue (Content is not within a landmark element) was not repeating and main tag and role is already available from main page so these changes are not required. I have reverted these changes. and updated the PR. please review. Thank you!.
| /> | ||
| <text | ||
| id="gauge-label" | ||
| <section id="main-content" aria-label="region"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @aqibibm ,as I said above. I have reverted these changes. and updated the PR. please review. Thank you!.
hi @aqibibm and Team , I was able to reproduce the issue “Accessible name does not match or contain the visible label text.”
|



closes : https://jsw.ibm.com/browse/MAXUIF-3195?filter=-1
Summary
components from carbon-addon-iot-react mentioned below.
Change List (commits, features, bugs, etc)
Acceptance Test (how to verify the PR)
Before :
Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iotorbxclass prefix is using the prefix variabledata-testidattribute. New test ids should have test written to ensure they are not changed or removed.