-
Notifications
You must be signed in to change notification settings - Fork 195
Updated public api, added exports for Legend/Roles enums and tools. #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Victor Gerritsen <[email protected]>
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-charts-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
All contributors have signed the DCO. |
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
|
Recheck |
|
Hi @vrg84, I'm curious why we'd want these functions being exported? these are internal tools that might change at any point |
The library doesn’t provide a grouped + stacked bar chart. Since we need this feature, we extended The helpers ( The goal of using the same helpers is keeping our custom chart behavior visually and functionally consistent with the library.
|
@vrg84 why not contribute the grouped stacked bar chart instead? |
I wish i could, i just dont have the time right now take it to where it needs to be. Its at a bare minimum to fit our needs. Having said that, i do realize the exposed tools are only ever used in creating a new chart / extending the functionality... i'll see if i can make time to create a proper issue for it instead and start/share the work, maybe more people can contribute. |
would you like to share your current code that achieves the grouped+stacked bar functionality? and maybe I could get it into the library, no promises though 🙂 |
Yes! I have no expectations since it seems like theres still a lot of work to do, but I ported it into my fork: I've taken some steps to make it run with a simple example (located in
But like i said, this implementation was tailored to our needs (it was the best i can do in a few days), this is still missing from the top of my head:
It was fun diving into the library and d3.js for a bit 😄thanks for your time! |



Updates
Core
LegendEventandRoles/packages/core/src/tools.ts.