Skip to content

fix: table item title not readable if class.toString not overridden #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: table item title not readable if class.toString not overridden #3174

wants to merge 1 commit into from

Conversation

silk-bahamut
Copy link
Contributor

Closes carbon-design-system/carbon-components-angular#3173

When using a class if toString is not overridden, the title of the table item is [object Object] which is not human readable

Changelog

Changed

  • TableItem.title: change check before using toString

@silk-bahamut silk-bahamut requested a review from a team as a code owner September 5, 2025 09:16
@netlify Netlify
Copy link

netlify bot commented Sep 5, 2025 •
edited
Loading

✅ Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 9ee7b4d
🔍 Latest deploy log https://app.netlify.com/projects/carbon-components-angular/deploys/68baaa6be830810008b5f0b0
😎 Deploy Preview https://deploy-preview-3174--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TableItem: default title for class is [object Object]
1 participant
@silk-bahamut