Skip to content

feat: convert input-label components to use OnPush change detection strategy #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

feat: convert input-label components to use OnPush change detection strategy #3182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ef865d
feat: on push strategy for password-input-label, part of carbon-desig…
maicongodinho Sep 29, 2025
6c5a222
feat: on push strategy for text-input-label, part of carbon-design-sy…
maicongodinho Sep 29, 2025
29416d5
feat: on push strategy for textarea-label, part of carbon-design-syst…
maicongodinho Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/input/password-input-label.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import {
TemplateRef,
ViewChild,
ChangeDetectorRef,
ContentChild
ContentChild,
ChangeDetectionStrategy
} from "@angular/core";
import { PasswordInput } from "./password.directive";
import { BaseIconButton } from "carbon-components-angular/button";
Expand Down Expand Up @@ -149,7 +150,8 @@ import { BaseIconButton } from "carbon-components-angular/button";
}
</div>
}
`
`,
changeDetection: ChangeDetectionStrategy.OnPush
})
/**
* Represents the Password Input Label Component.
Expand Down
4 changes: 3 additions & 1 deletion src/input/text-input-label.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {
AfterContentInit,
AfterViewInit,
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
ElementRef,
Expand Down Expand Up @@ -124,7 +125,8 @@ import {
}
</div>
}
`
`,
changeDetection: ChangeDetectionStrategy.OnPush
})
export class TextInputLabelComponent implements AfterViewInit, AfterContentInit {
/**
Expand Down
6 changes: 4 additions & 2 deletions src/input/textarea-label.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import {
TemplateRef,
ViewChild,
ContentChild,
ChangeDetectorRef
ChangeDetectorRef,
ChangeDetectionStrategy
} from "@angular/core";

import { TextArea } from "./text-area.directive";
Expand Down Expand Up @@ -137,7 +138,8 @@ import { TextArea } from "./text-area.directive";
}
}
}
`
`,
changeDetection: ChangeDetectionStrategy.OnPush
})
export class TextareaLabelComponent implements AfterViewInit {
/**
Expand Down