Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tile] update tile a11y #4439

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Tile] update tile a11y #4439

wants to merge 5 commits into from
+3,332 −3,152

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Jan 23, 2025

Closes #4185

Updating new a11y info for Tiles

Changelog

New

  • Updated to match the Accessibility Template
  • Added images
  • Added content

@thyhmdo thyhmdo requested review from a team as code owners January 23, 2025 18:47
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:12pm

@thyhmdo thyhmdo requested a review from laurenmrice January 24, 2025 14:05
@laurenmrice
Copy link
Member

Could a dev help re-deploy this PR so we can view the deploy preview? Thanks!

laurenmrice
laurenmrice approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ✅

Kritvi-bhatia17
Kritvi-bhatia17 reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thy! Amazing work!
Just wanted to confirm one small thing—it’s a minor detail and can be ignored if not necessary:

The multiselect tile gets selected when pressing either Space or Enter. Should we highlight this in both the text and the image?

image

Kritvi-bhatia17
Kritvi-bhatia17 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

guidari
guidari reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thyhmdo it might be a good a idea to open a new PR with these changes. For some reason your PR is updating files that it shouldn't be updated. Like the yarn files 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidari guidari guidari left review comments

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: one more review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tile] update a11y tab content for the Tile component
4 participants
@thyhmdo @laurenmrice @guidari @Kritvi-bhatia17