Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] update Style tab #4462

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Tooltip] update Style tab #4462

wants to merge 8 commits into from
+49 −104

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Feb 6, 2025 •
edited
Loading

Closes ##4449

Changelog

Changed

  • Removed icon button and standard tooltip triggers and combine them in a simpler format

Figma link to provide comments

https://www.figma.com/design/As6qRRd6KSDcNXQY25ZbAJ/Tooltip?node-id=466-13489&t=U0srolmIpWWuyHHZ-4

@thyhmdo thyhmdo requested a review from laurenmrice February 6, 2025 21:49
@thyhmdo thyhmdo requested review from a team as code owners February 6, 2025 21:49
@vercel Vercel

This comment was marked as outdated.

Sign in to view
@laurenmrice
Copy link
Member

@guidari When you get a chance, can you fix the deploy preview? Thank you!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

Deploy preview successfully published at https://4462--carbondesignsystem.netlify.app with commit (325a164)

kennylam
kennylam approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look good locally. Due to recent updates to the deploy preview workflow (#4469) the previews for this job are not showing the latest changes. I tried redeploying the action but the changes still don't appear. I think a PR using the new workflow should deploy correctly, we'll keep an eye on them.

@tay1orjones
Copy link
Member

tay1orjones commented Feb 24, 2025 •
edited
Loading

@kennylam I just updated the deploy preview workflow to avoid using the cache if the PR contains changes to images 9b7ef8a

I think it should resolve the issue here but I'll wait until the deploy comes through and test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@guidari guidari guidari approved these changes

@laurenmrice laurenmrice Awaiting requested review from laurenmrice

Assignees
No one assigned
Labels
status: one more review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thyhmdo @laurenmrice @tay1orjones @kennylam @alisonjoseph @guidari @alina-jacob