-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update accessibility.mdx #4475
base: main
Are you sure you want to change the base?
Update accessibility.mdx #4475
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
carbon-design-system/carbon#18607 is not limited to Link
components:
This issue doesn't just apply to the
Link
component. There are other Carbon components (e.g.,SideNavLink
,SideNavMenuItem
, etc.) that wrapa
elements whose accessibility guidelines say that the space key should be used to activate them. However, the Storybook entries (e.g., https://react.carbondesignsystem.com/?path=/story/components-ui-shell-sidenav--fixed-side-nav) that include these elements do not follow those guidelines.
I don't understand. Where are you seeing documentation on the SideNavLink, etc? I followed the link you provided and there is no occurrence of the word "space" in the documentation. Further, the SideNavLink is not a Carbon component. The only place I'm aware anything like that is documented is in the UI shell left panel, which has correct keyboard documentation. |
carbon-design-system/carbon#18607 (comment). All good, thanks. |
Deploy preview successfully published at https://4475--carbondesignsystem.netlify.app with commit (d789385) |
Closes carbon-design-system/carbon#18607
Closes #
{{short description}}
Changelog
New
Changed
Removed