Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accessibility.mdx #4475

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update accessibility.mdx #4475

wants to merge 3 commits into from

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Feb 18, 2025

Closes carbon-design-system/carbon#18607

Closes #

{{short description}}

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 3:14pm

Copy link

@adamalston adamalston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

carbon-design-system/carbon#18607 is not limited to Link components:

This issue doesn't just apply to the Link component. There are other Carbon components (e.g., SideNavLink, SideNavMenuItem, etc.) that wrap a elements whose accessibility guidelines say that the space key should be used to activate them. However, the Storybook entries (e.g., https://react.carbondesignsystem.com/?path=/story/components-ui-shell-sidenav--fixed-side-nav) that include these elements do not follow those guidelines.

@mbgower
Copy link
Contributor Author

mbgower commented Feb 19, 2025

This issue doesn't just apply to the Link component. There are other Carbon components (e.g., SideNavLink, SideNavMenuItem, etc.) that wrap a elements whose accessibility guidelines say that the space key should be used to activate them. However, the Storybook entries (e.g., https://react.carbondesignsystem.com/?path=/story/components-ui-shell-sidenav--fixed-side-nav) that include these elements do not follow those guidelines.

I don't understand. Where are you seeing documentation on the SideNavLink, etc? I followed the link you provided and there is no occurrence of the word "space" in the documentation.

Further, the SideNavLink is not a Carbon component. The only place I'm aware anything like that is documented is in the UI shell left panel, which has correct keyboard documentation.
image

@adamalston
Copy link

carbon-design-system/carbon#18607 (comment). All good, thanks.

Copy link
Contributor

Deploy preview successfully published at https://4475--carbondesignsystem.netlify.app with commit (d789385)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: The Link component and others don't comply with their accessibility guidelines
4 participants