Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict dependency on coordinate arrays #51

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

katamartin
Copy link
Member

This PR removes the strict requirement that all coordinate arrays be included in the store and fetched by ncview-js. Note that spatial coordinates are always required and non-spatial coordinates are still required for pyramid stores.

  • When a coordinate is not fetched, we fallback to rendering just the coordinate index information
  • When a non-spatial coordinate array (e.g., time) is missing:
    • We skip the get_array initialization step on the FetchStore
    • Show a missing message in the ArrayMetadata table
  • When a coordinate array is too large (over 1000000 values)
    • We skip fetching the array data via array.get_chunk()
  • Unrelated update caught in this PR: avoid showing a full time series when there is only a single data point in the regional plot

Closes #47

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 8:31pm

@katamartin katamartin merged commit 74809a3 into main Jan 15, 2025
8 checks passed
@katamartin katamartin deleted the katamartin/skip-coordinate-arrays branch January 15, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle missing and large coordinate arrays by falling back to index-based navigation
1 participant