Skip to content

fix(chart): fix support for more than 2 parties#79

Merged
sbckr merged 2 commits intomasterfrom
fix/multiple-player-support
Mar 18, 2025
Merged

fix(chart): fix support for more than 2 parties#79
sbckr merged 2 commits intomasterfrom
fix/multiple-player-support

Conversation

@sbckr
Copy link
Copy Markdown
Member

@sbckr sbckr commented Mar 13, 2025

As there are only changes to the tests for the service, it is not mentioned in the commit message to not trigger a new release

Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
@sbckr sbckr requested a review from strieflin March 13, 2025 10:29
@sbckr sbckr requested a review from a team as a code owner March 13, 2025 10:29
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (6707161) to head (01a03a3).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #79   +/-   ##
=========================================
  Coverage     90.15%   90.15%           
  Complexity      397      397           
=========================================
  Files            59       59           
  Lines          1483     1483           
  Branches         78       78           
=========================================
  Hits           1337     1337           
  Misses           93       93           
  Partials         53       53           
Flag Coverage Δ
service 93.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6707161...01a03a3. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

strieflin
strieflin previously approved these changes Mar 13, 2025
Copy link
Copy Markdown
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strieflin
Copy link
Copy Markdown
Member

There one Codacy finding that you could easily address :-).

Signed-off-by: Sebastian Becker <sebastian.becker@de.bosch.com>
Copy link
Copy Markdown
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit 30d4133 into master Mar 18, 2025
8 checks passed
@sbckr sbckr deleted the fix/multiple-player-support branch March 18, 2025 06:58
This was referenced Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants