Tn 1207 cms integration #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved the old handler function from 0.8.1 In serve public content, we correctly attach the data to controllerResult. In System for handling of public routes and node modules (Which is deprecated for all but core PB routes/pages) there was an issue where a callback function was not awaiting compleition before it was allow to continue the middleware stack. This was the reason for the error that we saw in the logs - all be it in a very long, round about, and obtuse way. It would not set the data on the req.controllerResult. When in Debug mode, that variable is referenced in recordEndTime middleware. That would error and cause it to fallback into the error handler which would render a new page and call through to the error controller. Which would go through and reset headers. By this point, that function that didnt get awaited correctly would have set the headers and sent the request - fulfilling the front end's needs. In Summary: Correctly sets the controller result int the serving of public routes. Correctly awaits the completion of serving public content before continuing the middleware stack. Remove dead code.
Fixing double setting headers and async breakdown
…gger Triiger the version process
…s db and to the request
…to-cms Feature/tn 970 migrate sf to cms
…-create-profile -dFeature/tn 970 redirect to create profile
…n-to-use-state-param-to-persist-data enabling state param to the login
…rity-to-create-profile Add highPriorityToRegister flag to the state params
….com:careerbuilder/pencilblue into Bugs/ACEAO-3825-Change-to-Career-Site-Footer
…ngToSF [TN-1219]Add language string to salesforce pages
…n-ie Bugfix/aceao 4399 search on ie
…n-ie fix ie issue with attr changes
…n-ie Bugfix/fix admin prefix issue
updated variable name as Youran suggested
updated variable name as Youran suggested
…Career-Site-Footer AO-3825: Logic for setting "set-cookies" to secure
vokidya
force-pushed
the
TN-1207-cms-integration
branch
from
b2fda8b to
9d82f96
Compare
vokidya
force-pushed
the
TN-1207-cms-integration
branch
from
9d82f96 to
bb14c93
Compare
vokidya
force-pushed
the
TN-1207-cms-integration
branch
from
7133ed9 to
aa4f408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description:
@pencilblue/owners