fix(BuildTools): forward --ros2 and --dds-middleware to UE4 editor command line - #9665
Merged
Blyron merged 1 commit intoApr 14, 2026
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
LuisPovedaCano
approved these changes
Apr 10, 2026
LuisPovedaCano
requested changes
Apr 13, 2026
LuisPovedaCano
left a comment
Contributor
There was a problem hiding this comment.
The Windows CI/CD failure is not caused by this PR's changes.
The cause is that the branch is 2 commits behind ue4-dev and is missing commit 364fd34
fatal error C1083: Cannot open include file: 'carla/ros2/dds/DDSMiddleware.h': No such file or directory
To fix it, just update the branch against current ue4-dev
JArmandoAnaya
force-pushed
the
fix/issue-9511-ros2-launch
branch
from
April 13, 2026 16:50
2ba4adb to
28d7910
Compare
Contributor
Author
|
Hello! Done, I already rebased from ue4-dev. |
Contributor
Author
|
It looks like Windows CI is still failing, but I saw the error, and it doesn't seem related to this PR or the ROS2 fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: fix(BuildTools): forward --ros2 and --dds-middleware to UE4 editor command line
Branch:
fix/issue-9511-ros2-launchBase:
ue4-devDescription
Fixes #9511
This PR is blocked on #9645.
When running
make launch ARGS="--ros2", the--ros2flag is consumed byBuildCarlaUE4.shfor build-time configuration (
OptionalModules.ini) but never forwarded to the UE4 editorprocess. At runtime,
CarlaSettings.cppchecksFParse::Param(TEXT("-ros2"))on the commandline, which always fails because the flag is missing.
This PR adds a forwarding block after the argument-parsing loop in both build scripts:
BuildCarlaUE4.sh:DDS_MIDDLEWAREvariable and--dds-middlewaregetopt option--ros2and--dds-middleware=<value>toEDITOR_FLAGSBuildCarlaUE4.bat:--ros2toEDITOR_FLAGSwhenUSE_ROS2is true--dds-middlewareon Windows (only FastDDS is supported)After the fix,
make launch ARGS="--ros2"produces:And
make launch ARGS="--ros2 --dds-middleware=cyclonedds"produces:Where has this been tested?
osrf/ros:humble-desktopcontainer,ros2 topic listconfirms/clockand all CARLA topics are publishedScript argument-parsing verified with 6 unit tests covering all flag combinations
(
--ros2only,--dds-middlewareonly, both, neither, combined with--editor-flags).Possible Drawbacks
None. The forwarding is additive and only activates when
--ros2or--dds-middlewareisexplicitly passed. Existing workflows without these flags are unaffected.
This change is