fix(streaming): make ServerSession::CloseNow idempotent on ue5-dev - #9761
Merged
LuisPovedaCano merged 3 commits intoMay 27, 2026
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
LuisPovedaCano
approved these changes
May 27, 2026
LuisPovedaCano
left a comment
Contributor
There was a problem hiding this comment.
This port looks good to me.
Approving to enqueue in CI, but please fix the comment.
| # pragma clang diagnostic pop | ||
| #endif | ||
|
|
||
| #include<atomic> |
Contributor
There was a problem hiding this comment.
Could you please add and space between the #include and atomic to match the code style fo the rest of the file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port of #9740 (ue4-dev) to ue5-dev.
Adds
std::atomic_bool _is_closed{false}toServerSessionand guardsCloseNow()with_is_closed.exchange(true)so the close path runs exactlyonce, preventing a double-disconnect from evicting a still-alive subscriber
from the world-snapshot stream.
Fixes #9759
Where has this been tested?
Possible Drawbacks
None expected. The change is minimal (~3 lines), platform-independent LibCarla C++, and matches the fix already approved for ue4-dev.
This change is