fix(Sensor): use point sampling for fisheye depth cubemap - #9840
Open
vesor wants to merge 1 commit into
Open
Conversation
## Summary - Use point sampling for the fisheye depth camera cubemap instead of linear filtering. - Prevents blended near/far depth values at cubemap face boundaries (phantom surfaces at silhouettes). - Aligns depth wide-angle lens behavior with semantic/instance segmentation cameras, which already use point sampling. # Test I didn't do much tests. I ran 4 fisheye depth camera on car in Town01 for several meters, and convert the depth image to point cloud. After this fix, the noisy flying points gone, and the point cloud looks much better. Just post the PR to let some one know this problem and provide a possible solution (without much test :(
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
I didn't do much tests. I ran 4 fisheye depth camera on car in Town01 for several meters, and convert the depth image to point cloud. After this fix, the noisy flying points gone, and the point cloud looks much better.
Just post the PR to let some one know this problem and provide a possible solution (without much test :(
Description
Fixes #
Where has this been tested?
Possible Drawbacks
This change is