Modify rviz_carla_plugin/CMakeLists.txt for a successful build with l… - #759
Open
rsoome wants to merge 1 commit into
Open
Conversation
…og4cxx version >=12.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from
log4cxxversion 0.12.0, it started usingstd::shared_ptras the smart pointer implementation. On systems (i.e Ubuntu22) that have that version or greater, the build fails with/usr/include/log4cxx/boost-std-configuration.h:10:18: error: 'shared_mutex' in namespace 'std' dose not name a type.This change will use cmake cxx standard 17 to build the
rviz_carla_pluginistead of cmake cxx standard 14 if it detects log4cxx version greater than or equal to 0.12.0.This change is