Bump clang-tidy to 19 and fix linter errors #306
Conversation
edubart
added
the
refactor
.clang-tidy
Outdated
| @@ -44,7 +43,6 @@ Checks: >- | |||
| -readability-function-cognitive-complexity, | |||
| -readability-identifier-length, | |||
| -readability-magic-numbers, | |||
| -readability-enum-initial-value, | |||
There was a problem hiding this comment.
I don't really like this. The standard is pretty clear about what the values would be. So no need to enforce use writing +1, +2 etc. Really, I have no idea why somebody thinks this is less error prone.
src/virtio-p9fs.h
Outdated
| @@ -55,73 +55,73 @@ enum virtio_p9fs_constants : uint32_t { | |||
| /// \brief 9P2000.L opcodes | |||
| enum p9_opcode : uint8_t { | |||
| P9_TLERROR = 6, | |||
There was a problem hiding this comment.
This here was just being lazy. :)
src/machine-reg.h
Outdated
| @@ -177,15 +177,15 @@ enum class machine_reg : uint64_t { | |||
| uarch_last_ = uarch_x31, | |||
|
|
|||
| // Views of registers | |||
| htif_tohost_dev, | |||
There was a problem hiding this comment.
How do you know PMA_SHADOW_STATE_LENGTH+8 doesn't fall inside PMA_SHADOW_UARCH_STATE? See? The compiler will not warn about repeated enums, because we use repeated enums all the time.
| @@ -795,7 +795,7 @@ const pma_entry &machine::find_pma_entry(const CONTAINER &pmas, uint64_t paddr, | |||
|
|
|||
| template <typename T> | |||
There was a problem hiding this comment.
I want to get rid of this entirely. I want to remove machine::find_pma_entry altogether, and have the update_merkle_tree_page or whatever that uses it t o simply use std::find on the m_merkle_pmas array.
edubart
force-pushed
the
refactor/clang-19-linter
branch
from
da65e33 to
711f920
Compare
No description provided.