Open
Conversation
7 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
7 tasks
brunomenezes
force-pushed
the
feat/application-summary-page
branch
from
007b70a to
8bd8a9e
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new “application home/summary” page under /apps/[application] to present high-level application stats and quick navigation, while refactoring shared container layout and improving theme/Storybook color-scheme behavior.
Changes:
- Introduces
ApplicationSummaryPage+ container and wires application navigation to land on the summary page instead of directly on epochs. - Refactors container layout spacing via a shared
ContainerStackand reuses the sharedQueryPaginationinOutputList. - Sets global Mantine
Spoilerdefaults via theme, adds animated counters (TweenedNumber), and updates Storybook preview to sync color-scheme changes.
Reviewed changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds @react-spring/web and updates lockfile snapshots. |
| apps/dave/package.json | Adds @react-spring/web dependency; expands clean script. |
| apps/dave/src/app/apps/[application]/page.tsx | Adds new route entry for the application summary page. |
| apps/dave/src/containers/ApplicationSummaryContainer.tsx | Fetches summary datasets and renders ApplicationSummaryPage. |
| apps/dave/src/page/ApplicationSummaryPage.tsx | New summary UI (counts, latest epochs/inputs, active tournament link). |
| apps/dave/src/page/ApplicationSummaryPage.stories.tsx | Storybook story for the new summary page. |
| apps/dave/src/components/SummaryCard.tsx | New summary metric card component. |
| apps/dave/src/components/TweenedNumber.tsx | New animated number component for metric values. |
| apps/dave/src/containers/ContainerStack.tsx | New shared container layout wrapper (spacing defaults). |
| apps/dave/src/containers/*Container.tsx | Updates containers to use ContainerStack and updated breadcrumbs. |
| apps/dave/src/components/QueryPagination.tsx | Improves pagination calculations for edge cases. |
| apps/dave/src/components/output/OutputList.tsx | Refactors to use QueryPagination and updated types. |
| apps/dave/src/providers/theme.ts | Adds theme-level defaults for Mantine Spoiler. |
| apps/dave/mantine.d.ts | Augments Mantine types for SpoilerProps customization. |
| apps/dave/src/components/*View.tsx | Uses themed Spoiler defaults by removing repeated props. |
| apps/dave/.storybook/preview.tsx | Reworks Storybook decorators and color-scheme syncing logic. |
| apps/dave/src/components/navigation/Hierarchy.tsx | Adjusts sticky offset calculation. |
| .prettierignore | Ignores generated sources under src/generated. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Also include creation of container-stack to make standard the spacing between elements inside containers.
* Also update our custom mantine.d.ts to to make TS aware of the change.
brunomenezes
force-pushed
the
feat/application-summary-page
branch
from
0033119 to
8cd61ac
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 31 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code changes to add an "application home" instead of navigating straight to the list of epochs. The page contains a summary of the current status of application. tldr: Summary of status and quick access to epochs and active tournament if there is one.
Also, refactor a few components and improve syncing of colour-scheme changes between the Storybook toolbar and the switch in the application header. The commits are separated so it is easy to follow the changes if needed.
It closes the issue: #425
A test can be performed using the latest Cartesi CLI, ensuring the mock is disabled (default). Or a running rollups-node with an application, but update the environment variables accordingly.
But here is a storybook chromatic link: Application Summary Story
PS: In the in the chromatic story page just don't click the anchors because it is a Story and leads nowhere.