Skip to content

Fix crash when the key is not found. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skorokithakis wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix crash when the key is not found. #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57822e1
Fix crash when the key is not found.
skorokithakis Jan 22, 2012
6b51585
Actually fix the bug.
skorokithakis Jan 22, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion la_facebook/callbacks/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def redirect_url(self, request, fallback_url=settings.LOGIN_REDIRECT_URL,
logger.debug("redirect not in get params")
# try the session if available
if hasattr(request, "session"):
redirect_to = request.session.get(session_key_value)
redirect_to = request.session.get(session_key_value, "")
if redirect_to is None: redirect_to = ""
# Heavier security check -- don't allow redirection to a different host.
netloc = urlparse.urlparse(redirect_to)[1]
if netloc and netloc != request.host:
Expand Down