Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce inclusive naming check and update existing language #977

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

aaronshurley
Copy link
Contributor

What this PR does / why we need it:

This addresses https://github.com/vmware-tanzu/carvel/issues/594

Which issue(s) this PR fixes:

Fixes https://github.com/vmware-tanzu/carvel/issues/594

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@aaronshurley
Copy link
Contributor Author

created as a draft until https://github.com/vmware-tanzu/carvel/pull/595 lands

We are following the Inclusive Naming Initiative's guidance as that is what the
CNCF supports.
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronshurley aaronshurley merged commit cc21009 into develop Nov 28, 2022
@aaronshurley aaronshurley deleted the inclusive-naming branch November 28, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carvel repos follow the INI's inclusive naming practices
3 participants