Fixed sub-depds that interfered with Service Radar - #18
Merged
Conversation
…ers. All tests are passing. Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bgpkit-parser's default features are ["parser", "rustls"], where rustls = ["oneio/rustls"]. That drags in oneio, bgpkit's remote-fetch layer, and with it a full HTTP/S3/FTP stack: reqwest, hyper-rustls, rust-s3, aws-creds, attohttpc, rust-ini.
arancini-lib doesn't use any of it. Its entire bgpkit surface is bgpkit_parser::bmp::messages::* and bgpkit_parser::models::* — in-memory decoding of BMP frames arriving over a TCP socket. There is no BgpkitParser::new(url), no URL, no oneio reference anywhere in the crate.
Setting default-features = false, features = ["parser", "serde"] keeps exactly what's used (parser gates models/bmp; serde is already declared) and drops the rest. Measured downstream in ServiceRadar: 34 packages leave Cargo.lock.
Because features are additive and unify across the graph, any consumer that also depends on bgpkit-parser inherits rustls today and cannot opt out — so this can only be fixed here.
Consumers who do want remote fetching can still opt in with features = ["rustls"], so this isn't a breaking change in capability