Move Gradle build files to Kotlin Syntax; Version catalog#165
Closed
pedronveloso wants to merge 2 commits into
Closed
Move Gradle build files to Kotlin Syntax; Version catalog#165pedronveloso wants to merge 2 commits into
pedronveloso wants to merge 2 commits into
Conversation
pedronveloso
requested review from
Egorand,
darkpiston,
drewhamilton,
frostyshadows and
kylemboos
pedronveloso
commented
Feb 3, 2026
Comment on lines
38
to
40
Contributor
Author
There was a problem hiding this comment.
I removed jvmToolchain on all of these on a later PR
Egorand
approved these changes
Feb 4, 2026
There was a problem hiding this comment.
nit: maybe worth moving this comment into libs.versions.toml, since the version is now declared there?
Contributor
Author
|
Closing this PR as this change was bundled as part of another PR. Moved the fixes from the feedback here into this PR: #164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate existing Gradle Build files to Kotlin syntax, and adopt Version Catalog for dependency versioning; for all existing modules.