Conversation
|
thanks for the PR @d4rp4t ! do you think this could be tested with an integration test? This would not only verify it works as expected, it also gives implementors an up to date example. |
There was a problem hiding this comment.
Great work @d4rp4t! Love the use of exponential backoff, and the implementation looks solid (eyeballed: have not had a chance to test). I've noted a couple of minor nits and some suggestions for your consideration.
robwoodgate
left a comment
robwoodgate
left a comment
There was a problem hiding this comment.
Would be a good spot to leverage our new logger as well
a1denvalu3
left a comment
a1denvalu3
left a comment
There was a problem hiding this comment.
In a follow up to this PR we should make it possible to pass in a callback that takes in the request payload as a parameter, so the implementor can actually persist the payload data somewhere if they want to.
|
@d4rp4t is this ready? |
|
@lollerfirst The logic itsef - yes, but i haven't implemented it in any method yet. |
|
#356 related, since i'll be able to write integration tests with the CDK mint |
robwoodgate
force-pushed
the
nut19-cache
branch
from
673ecb8 to
209a6ea
Compare
|
@d4rp4t - I've rebased this to development (v3) as discussed. Please can you check it over. |
robwoodgate
added
the
needs rebase
d4rp4t
force-pushed
the
nut19-cache
branch
2 times, most recently
from
f475cc7 to
1cb5f11
Compare
Egge21M
left a comment
Egge21M
left a comment
There was a problem hiding this comment.
Thank you so much for picking this up again! This already looks very solid. I left a couple notes on on the global options. Conceptionally the only thing that needs some thought is the backoff count and timer, leading to very very long promises in network failure situations.
robwoodgate
removed
the
needs rebase
|
Hav
Code looks great now these items have been addressed. Let's talk about the broader point raised and callbacks in our meeting this week? |
Add fancy integration tests
Restore mocks after tests Use superstrings instead of not-working (anymore) string interpolation in logger Avoid setting global request options
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18c6b3c49e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1667153cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
robwoodgate
left a comment
robwoodgate
left a comment
There was a problem hiding this comment.
@d4rp4t - hope you don't mind, I fixed up the AbortController issue and a couple of nits highlighted by codex.
This looks really solid, you've done an amazing job on it.
LGTM!
|
@robwoodgate woah, thanks for fixing my mistakes. glad that we finally managed to finish it! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9acf8e1b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b5cdffe9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
LGTM |
7 participants
Fixes: #328
Description
Adds internal support for retrying cached requests according to NUT-19, based on exponential backoff.
Changes
request.ts
MintInfo.ts
Other
Note: Cached request usage is not yet implemented in the CashuMint class — waiting for approval.
PR Tasks
npm run test--> no failing unit testsnpm run format