feat(jsonint): add bigint-safe JSON parsing and mint normalization by robwoodgate · Pull Request #519 · cashubtc/cashu-ts

robwoodgate · 2026-02-24T21:17:19Z

Description

Introduces a BigInt-safe JSON parser/stringifier and wires it into request/response handling, with Mint response normalization to keep the public v3 API stable while supporting bigint as "numeric digits" in JSON payloads.

Key changes

Add src/utils/JSONInt.ts (BigInt‑safe JSON parse/stringify, Crockford-style parser with __proto__ protection).
Wire transport to use JSONInt for request bodies and response parsing (src/transport/request.ts).
Add/extend Mint response normalization to accept bigint-compatible wire values while keeping v3 numeric output types stable (src/mint/Mint.ts).
Export JSONInt from utils (src/utils/index.ts).
Add comprehensive JSONInt tests

Notes / v4 direction

This keeps v3 public API types as number, but makes bigint safe on the wire and through internal normalization.
v4 can remove the tolerant fallbacks and return Amount directly from Mint responses.

robwoodgate · 2026-02-25T00:13:54Z

src/transport/request.ts

-	error?: string;
 	code?: number;
-	detail?: string;
+	detail?: unknown;


This might technically be breaking for someone importing deep (it's not in public API). But it seems mints can return more than strings, eg:

curl -sS -X POST "https://mint.minibits.cash/Bitcoin/v1/mint/quote/bolt11" \ -H "Content-Type: application/json" \ -d '{}' {"detail":[{"type":"missing","loc":["body","unit"],"msg":"Field required","input":{}},{"type":"missing","loc":["body","amount"],"msg":"Field required","input":{}}]}

robwoodgate · 2026-02-25T00:20:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d22bf9d96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/mint/Mint.ts

src/utils/JSONInt.ts

robwoodgate · 2026-02-25T16:39:52Z

@codex review - is this good to go?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c212744ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/mint/Mint.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c440f89fd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/transport/request.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42018ee0ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/mint/Mint.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42018ee0ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/mint/Mint.ts

src/utils/JSONInt.ts

chatgpt-codex-connector · 2026-02-26T08:49:21Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

robwoodgate · 2026-03-06T08:55:26Z

Rebased to main, no longer stacked.

robwoodgate · 2026-03-06T08:57:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 066e05ecc0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/transport/request.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04fb30e3cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-07T00:00:21Z

src/transport/request.ts

+		if (!responseText) {
+			throw new Error('Empty response body');
+		}
+		return JSONInt.parse(responseText);


Normalize /v1/keysets numeric fields before returning data

Parsing all successful responses via JSONInt.parse now converts oversized integer tokens to bigint, but Mint.getKeySets() returns that payload directly and downstream wallet logic treats input_fee_ppk as a number (getFeesForKeyset multiplies nInputs * feePPK). When a mint sends a /v1/keysets value above Number.MAX_SAFE_INTEGER, this regression causes runtime Cannot mix BigInt and other types errors in fee computation instead of preserving the v3 number contract, so keyset numeric fields should be normalized (or rejected) at the mint boundary.

Useful? React with 👍 / 👎.

fix(mint): preserve normalized melt fields

Normalize melt and restore amounts to prevent bigint leaks.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19b3e7826a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-10T09:02:23Z

src/utils/JSONInt.ts

+			case 'object': {
+				if (val === null) return 'null';


Unbox boxed primitives before object serialization

JSONInt.stringify treats every non-null object as a plain object, so boxed primitives like new Number(2), new Boolean(false), and new String('x') are serialized as {}, {}, or indexed objects instead of primitive JSON values. Since src/transport/request.ts now uses this serializer for all request bodies, JS callers who pass boxed values can send malformed payloads to mint endpoints (for example an amount becomes {}), which is a regression from the previous JSON.stringify behavior.

Useful? React with 👍 / 👎.

github-project-automation bot added this to cashu-ts Feb 24, 2026

github-project-automation bot moved this to Backlog in cashu-ts Feb 24, 2026

robwoodgate commented Feb 25, 2026

View reviewed changes

robwoodgate requested a review from Egge21M February 25, 2026 00:16

robwoodgate mentioned this pull request Feb 25, 2026

All amounts and key amounts need to be BigInt #437

Open

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

src/mint/Mint.ts Outdated Show resolved Hide resolved

src/utils/JSONInt.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

src/mint/Mint.ts Outdated Show resolved Hide resolved

robwoodgate force-pushed the bigint-json branch from 5c21274 to c440f89 Compare February 25, 2026 17:31

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

src/transport/request.ts Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

src/mint/Mint.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

src/mint/Mint.ts Outdated Show resolved Hide resolved

src/utils/JSONInt.ts Outdated Show resolved Hide resolved

Base automatically changed from bigint-amounts to main March 4, 2026 11:06

robwoodgate force-pushed the bigint-json branch from e7ceb97 to 066e05e Compare March 6, 2026 08:49

robwoodgate added the needs review PR needs reviewers to give it the green light label Mar 6, 2026

robwoodgate moved this from Backlog to Needs Review in cashu-ts Mar 6, 2026

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

src/transport/request.ts Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 7, 2026

View reviewed changes

robwoodgate added 8 commits March 10, 2026 08:46

feat(jsonint): add bigint-safe JSON parsing and mint normalization

d578d43

chore: fix error handling

7307f68

fix(jsonint): compute safe limits lazily only when BigInt exists

f7cb455

fix(mint): preserve normalized melt fields

fix(mint): fail fast on invalid amount normalization

2d57571

fix(mint): normalize melt and restore amounts

c6e35ed

Normalize melt and restore amounts to prevent bigint leaks.

fix(jsonint): match array reviver delete semantics

c84868e

fix(mint): normalize fee_reserve in melt responses

58fdb8b

fix(jsonint): detect and throw on circular references

c39ed8b

fix(jsonint): match native JSON - return undefined if root is undefined

19b3e78

robwoodgate force-pushed the bigint-json branch from 04fb30e to 19b3e78 Compare March 10, 2026 08:53

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

fix: simplify mint bigint shim

852c27a

Conversation

robwoodgate commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Key changes

Notes / v4 direction

Uh oh!

robwoodgate Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

robwoodgate commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

robwoodgate commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Feb 26, 2026

Uh oh!

robwoodgate commented Mar 6, 2026

Uh oh!

robwoodgate commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

robwoodgate commented Feb 24, 2026 •

edited

Loading