forked from freedombox/FreedomBox
-
Notifications
You must be signed in to change notification settings - Fork 0
Snapper (for feedback) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SunilMohanAdapa
wants to merge
198
commits into
master
Choose a base branch
from
386-snapper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (552 of 552 strings)
Currently translated at 100.0% (537 of 537 strings)
monkeysphere: Run publish as background task, allow user to cancel. Small fixes to names module: - Remove unused ugettext import. - Change SERVICES to tuple. - If a domain is not available for a service type, return None instead of (translated) "Not Available". - Rename get_services -> get_enabled_services.
Action: - Don't use const for HOST_TOOL, it is unlikely to be ever changed. - Don't pass multiple key ids as single string to monkeysphere-host. - Use JSON for data transfer with action instead of custom format and parsing. - Minor styling fixes. Template: - More consistent indentation. - Improve the description. - Add headers to the table. - List domains instead of domain types. URLs: - Take domain as argument for key generation. - Narrow down fingerprint matching regex. Views: - Take domain as argument for key generation. Verify that domain is valid. - Minor grammer fix to cancel message. - Use JSON format for getting key status. - List domains instead of domain types.
This is the first implementation for obtaining certificates from Let's Encrypt. Following the features and limitations. - Requires manual operation. - Registrations are done anonymously. - Supports revoking and re-obtaining certificates. Does not have a way to show if a certficate is already renewed. - Automatic renewal is not available. - Details messages in case of errors. - Has ability to switch to testing mode by using LE's staging servers. - Sets up Apache configuration for the domain and enables/disables it. When certificates are not available for a domain, default website configuration is used. When certificates are available, separate SSL website configuration for each domain is used. - Many domain will work with a single IP address with the help of Server Name Indication (SNI) which is supported by all modern browsers. - Supports diagnostics on websites.
Currently translated at 100.0% (537 of 537 strings)
Currently translated at 100.0% (537 of 537 strings)
Currently translated at 18.5% (104 of 562 strings)
Currently translated at 42.0% (226 of 537 strings)
Currently translated at 100.0% (552 of 552 strings)
- Closes #366 and closes #304 (all sub-tasks). - Start new process group with setsid() by sending start_new_session=True - Detach from parent process fds by closing all FDs and attaching stdin, stdou and stderr to /dev/null. - Don't wait for the process to complete. - This allows for upgrading Plinth while upgrades are trigged from Plinth itself. - Show log of upgrade exection instead of output and error log of the process which can no longer be collected. This has the advantage of showing automatic executions also. - Rewrite the mechanism to detect whether upgrades can be run. It is now based on whether the package manager is busy. This has the advantage of working properly if other apt processes are running, automatic upgrades are running, etc. - Busy status works even if Plinth is restarted while upgrades are in progress. - More descriptive messages showing that upgrades don't have to be triggered manually. - Warn that other packages can't be installed while upgrades are running, which may take a long time. - Warn the users of potential temporary unavailability of Plinth/Apache2.
Currently translated at 40.0% (225 of 562 strings)
- Take the value from the configuration and run it throught the Django translate method and make it available in Context. - Use a no-op translate method to translate the text 'FreedomBox'.
This method is useful to format strings that are lazy (such as those in Forms).
Using brand name directly from configuration means that it can't be easily translated. Instead use the translated brand name sent in my the context processor.
- Closes #375 and #380.
- More use of configurable brand name.
- So that translations on the changed messages can begin.
Currently translated at 40.2% (226 of 562 strings)
… for pre-backup situation
As reported by Jan Costermans, it is possible that for an access point scanned by a Wi-Fi device, get_ssid() returns None. The reported as follows: if access_point.get_ssid().get_data() == ssid: AttributeError: 'NoneType' object has no attribute 'get_data'
These files are not executed directly, but through ikiwiki's setup command.
In user visible strings, instead of PGP or GPG.
Filter letsencrypt domains from snakeoil list. Rename views for snakeoil and letsencrypt.
- Read Apache configuration to find the list of all available certificates and their associated domains. Use this for setting UIDs properly. - Solve the issue of re-importing renewed certficiate. Use the SSH fingerprints as unique keys instead of domain names. Compute SSH fingerprints for SSH keys and HTTPS certficates inorder accurately identify if they are currently imported into monkeysphere. - Allow having more than one domains for a certficiate. Add action to import new domains to an existing monkeysphere OpenPGP key. - Import only once for a given certficiate and keep adding UIDs when domains get added. - Merge services SSH and HTTPS giving us the ability to deals with many more services. Remove special handling for different kinds of certificate sources. - Supress monkeysphere prompts in case of reusing UIDs.
Currently translated at 99.2% (564 of 568 strings)
Currently translated at 35.1% (200 of 569 strings)
- Installing dbcommon-pgsql and not install dbcommon-mysql does not ensure that PostgreSQL is selected as the database for the application. Set a debconf value to force selection of PostgreSQL. - Minor styling fixes.
Start DBus daemon to ensure PackageKit can use it. Only start if it is not already running. Stop after setup. Stop only if we have started it.
…dates dynamicdns source string corrections
… for pre-backup situation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a pull request just to record some feedback for you:
(also we usually style as 'FreedomBox')
firewall that ports have to be opened up. This service notification
mechanism is only relevant for daemons which need to open ports in firewall.
branch, you may need to update your code accordingly.
it requires root permissions,
get_current_time_zone() etc.