Skip to content

WR-483012 Fix PHP 8.2 deprecation for dynamic property $rows #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillogo merged 1 commit into from
Mar 10, 2026
Merged

WR-483012 Fix PHP 8.2 deprecation for dynamic property $rows #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions classes/admin_setting_sql_textarea.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class admin_setting_sql_textarea extends \admin_setting_configtextarea {
/** @var int Minimum number of rows to display. */
const MIN_ROWS = 3;

/**
* Returns an XHTML string for the editor, sized to fit the current content.
*
Expand All @@ -39,8 +36,6 @@ class admin_setting_sql_textarea extends \admin_setting_configtextarea {
* @return string
*/
public function output_html($data, $query = '') {
$this->rows = max(self::MIN_ROWS, substr_count($data, "\n") + 2);

$html = parent::output_html($data, $query);

$id = $this->get_id();
Expand Down
Loading