Add Unscoped Capture Logger #3010
Conversation
Riyuzak2510
force-pushed
the
UNSCOPED_CAPTURE_LOGGER
branch
from
b6d1042 to
d34e490
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3010 +/- ##
==========================================
+ Coverage 90.92% 90.95% +0.03%
==========================================
Files 201 201
Lines 8653 8659 +6
==========================================
+ Hits 7867 7875 +8
+ Misses 786 784 -2 🚀 New features to boost your workflow:
|
Riyuzak2510
force-pushed
the
UNSCOPED_CAPTURE_LOGGER
branch
6 times, most recently
from
4e18ef2 to
98c9b6f
Compare
Riyuzak2510
force-pushed
the
UNSCOPED_CAPTURE_LOGGER
branch
from
c3d0075 to
abfdfcf
Compare
src/catch2/catch_message.hpp
Outdated
| std::vector<MessageInfo> getMessageDetails() const { | ||
| return m_messages; | ||
| } |
There was a problem hiding this comment.
This is not used anymore. For next time, this shouldn't be returning the vector by value, but by reference, and be ref-qualified if needed.
src/catch2/catch_message.hpp
Outdated
| void captureUnscopedValue( size_t index, std::string const& value ); | ||
|
|
||
| template<typename T> | ||
| void captureUnscopedValues( size_t index, T const& value ) { | ||
| captureUnscopedValue( index, Catch::Detail::stringify( value ) ); | ||
| } | ||
|
|
||
| template<typename T, typename... Ts> | ||
| void captureUnscopedValues( size_t index, T const& value, Ts const&... values ) { | ||
| captureUnscopedValue( index, Catch::Detail::stringify(value) ); | ||
| captureUnscopedValues( index+1, values... ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's not duplicate these, and instead add bool isScoped parameter to the constructor of Capturer, which will be kept to decide whether captureValue should create scoped or unscoped msg.
src/catch2/catch_message.cpp
Outdated
| getResultCapture().emplaceUnscopedMessage(Catch::MessageBuilder( | ||
| m_messages[index].macroName, | ||
| m_messages[index].lineInfo, | ||
| m_messages[index].type) << m_messages[index].message); |
There was a problem hiding this comment.
No need to copy the value into message first and then write it into the msg builder stream.
src/catch2/catch_message.hpp
Outdated
| #define UNSCOPED_INFO( msg ) (void)(0) | ||
| #define WARN( msg ) (void)(0) | ||
| #define CAPTURE( ... ) (void)(0) | ||
| #define UNSCOPED_CAPTURE( ... ) (void)(0) |
There was a problem hiding this comment.
Please re-align the empty definitions for the whole block. (And same for the one around line 150)
Riyuzak2510
force-pushed
the
UNSCOPED_CAPTURE_LOGGER
branch
from
466e345 to
d1ede1a
Compare
Riyuzak2510
force-pushed
the
UNSCOPED_CAPTURE_LOGGER
branch
from
d1ede1a to
7c551dd
Compare
|
@horenmar feel free to take a look |
Riyuzak2510
force-pushed
the
UNSCOPED_CAPTURE_LOGGER
branch
from
7c551dd to
9f4c665
Compare
Riyuzak2510
force-pushed
the
UNSCOPED_CAPTURE_LOGGER
branch
from
9f4c665 to
5abeb26
Compare
| std::vector<MessageInfo> m_messages; | ||
| IResultCapture& m_resultCapture; | ||
| size_t m_captured = 0; | ||
| bool isScoped; |
There was a problem hiding this comment.
Take a second look at how the other class variables are named.
| m_resultCapture.pushScopedMessage( m_messages[index] ); | ||
| m_captured++; | ||
| if(isScoped){ | ||
| assert( index < m_messages.size() ); |
There was a problem hiding this comment.
The assert should live at the start of the function, both branches access m_messages[index].
| if(index == m_messages.size() - 1){ | ||
| m_messages.clear(); | ||
| } |
There was a problem hiding this comment.
No need to clear this here, instead check in destructor whether m_isScoped is true and change it accordingly.
Adding Unscoped Capture Logger as a part of #2954
Description
Added Unscoped Capture Logger Feature as required to print details related to Capture
GitHub Issues
Closes #2954