feat(nixos): add support for where-is-my-sddm-theme
#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeitorAugustoLN
force-pushed
the
where-is-my-sddm-theme
branch
3 times, most recently
from
c2aad6d to
ea97d1e
Compare
isabelroses
reviewed
Apr 11, 2025
HeitorAugustoLN
force-pushed
the
where-is-my-sddm-theme
branch
from
ea97d1e to
8967283
Compare
isabelroses
force-pushed
the
where-is-my-sddm-theme
branch
from
8967283 to
713a158
Compare
Member
|
This will currently error on the fact that |
getchoo
reviewed
Apr 13, 2025
| { | ||
| options.catppuccin.where-is-my-sddm-theme = | ||
| catppuccinLib.mkCatppuccinOption { | ||
| name = "where-is-my-sddm-theme"; |
Member
There was a problem hiding this comment.
Suggested change
| name = "where-is-my-sddm-theme"; | |
| name = "where-is-my-sddm-theme"; | |
| default = config.catppuccin.sddm.enable || config.catppuccin.enable; | |
| defaultText = "config.catppuccin.sddm.enable || config.catppuccin.enable"; |
I think this will fix the conflict with our base SDDM module
HeitorAugustoLN
force-pushed
the
where-is-my-sddm-theme
branch
3 times, most recently
from
a59e4b0 to
69289d9
Compare
HeitorAugustoLN
force-pushed
the
where-is-my-sddm-theme
branch
from
69289d9 to
164e9de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
catppuccin/where-is-my-sddm-themenix resources intocatppuccin/nix(catppuccin/palette#97 (comment))