feat(brave-search): rewrite #2072
Conversation
uncenter
force-pushed
the
feat/brave-search-rewrite
branch
from
7cb732d to
c007925
Compare
WalkQuackBack
added
3.difficulty: significant/rewrite
|
@uncenter thank you for your work here (and @bitbloxhub for the initial finding and fixing). the changes look good to me, however since i'm currently on vacation without access to a pc i can't test this, sorry. i will approve the MR nonetheless so the fix can be merged. i will properly test this next week and open a new MR if necessary. |
|
I would like to review this before merging, if that's okay. Should be able to do it in a few hours. |
|
@uncenter I tested it now and found that at least for me the settings and quick settings were unstyled, so I re-added two css properties. now everything looks good to me. @WalkQuackBack did you find anything and/or can you check again with my changes? |
| fade(@peach, 15%) 3%, | ||
| fade(@pink, 15%) 40%, | ||
| fade(@mauve, 15%) 99% | ||
| ) border-box; |
There was a problem hiding this comment.
Could this be replaced with background-image so there's no border-box?
| 90deg, | ||
| @surface0 0%, | ||
| @surface1 100% | ||
| ) border-box !important; |
There was a problem hiding this comment.
WalkQuackBack
left a comment
WalkQuackBack
left a comment
There was a problem hiding this comment.
@uncenter I tested it now and found that at least for me the settings and quick settings were unstyled, so I re-added two css properties. now everything looks good to me.
@WalkQuackBack did you find anything and/or can you check again with my changes?
Will try to do a deeper review later today. Left some comments on things I'm unsure about. Otherwise, looks good!
3 participants
Rewrites the Brave Search userstyle after recent updates. Supersedes #2066.