Skip to content

Upgrade all third-party actions and pin them to immutable releases - #163

Merged
jeancochrane merged 1 commit into
mainfrom
jeancochrane/upgrade-actions
May 22, 2026
Merged

jeancochrane merged 1 commit into
mainfrom
jeancochrane/upgrade-actions

Conversation

@jeancochrane

@jeancochrane jeancochrane commented May 21, 2026 •

Copy link
Copy Markdown
Member

This PR upgrades all of our third-party GitHub Actions to ensure they are compatible with the upcoming Node 20 deprecation.

While we're at it, we also switch all of our references to third-party actions to point to immutable releases, so as to protect ourselves from the the ongoing scourge of supply chain attacks against third-party actions. If an action repo is using immutable releases, we pin to a specific immutable release; otherwise, we pin to the commit hash for the latest release of that action.

Test workflows to confirm these upgrades don't break anything:

Connects https://github.com/ccao-data/aws-infrastructure/issues/59.

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout does not use immutable releases, so we need to pin to the commit hash for the most recent release.


- name: Install uv
uses: astral-sh/setup-uv@v5
uses: astral-sh/setup-uv@v8.1.0

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

astral-sh/setup-uv does use immutable releases, so we can pin to a specific version and have confidence that a malicious actor cannot change it. We can confirm that the release is immutable by looking for the 🔒 Immutable icon on the release page:

Image

uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd

- name: Run pre-commit checks
uses: ccao-data/actions/pre-commit@main

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We control this action, so we don't need to pin it to a specific release.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I spent a really long time trying to figure this out until I realized this comment points to line 16, not line 13 🤦‍♂️

@jeancochrane
jeancochrane marked this pull request as ready for review May 21, 2026 16:57

@wagnerlmichael wagnerlmichael left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Sorry evil hackers!

uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd

- name: Run pre-commit checks
uses: ccao-data/actions/pre-commit@main

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I spent a really long time trying to figure this out until I realized this comment points to line 16, not line 13 🤦‍♂️

@jeancochrane
jeancochrane merged commit 2a9ebcf into main May 22, 2026
4 checks passed
@jeancochrane
jeancochrane deleted the jeancochrane/upgrade-actions branch May 22, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants